not every KiWIS request has optional fields

fluves / pywaterinfo

Python package to download time series data from waterinfo.be

https://fluves.github.io/pywaterinfo/

MIT License

17 stars 9 forks source link

not every KiWIS request has optional fields #42

Closed binomaiheu closed 3 years ago

binomaiheu commented 3 years ago

Some KiWIS request don't have optional fields, e.g. getColorClassifications, so first checking whether the request is available, otherwise returning empty set.

github-actions[bot] commented 3 years ago

:point_left: Launch a binder notebook on this branch

binomaiheu commented 3 years ago

No idea why this test for get_timeseries_value_layer is failing

tests/test_waterinfo.py::TestTimeseriesValueLayer::test_hic FAILED [ 90%]

and the others are cancelled, checked offline and works fine. In any case the change in this PR is not very exciting, so suggest to just merge as is...