search

fluves / pywaterinfo

Python package to download time series data from waterinfo.be
https://fluves.github.io/pywaterinfo/
MIT License
17 stars 9 forks source link

Add support for datetime with zoneinfo tzinfo #48

Closed dbkhout closed 2 years ago

dbkhout commented 2 years ago

Identical to https://github.com/fluves/pywaterinfo/pull/46, but from my forks datetime branch instead of its main one. Thanks for the suggestions @stijnvanhoey!

stijnvanhoey commented 2 years ago

@dbkhout thanks a lot. Would you be able to include the pre-commit issues yourself? See the development information, specific the section on pre-commit hooks? If not, I'll have a look later on.

Apart from that, we have connection issues with hic (see e.g. https://github.com/fluves/pywaterinfo/runs/4895965604?check_suite_focus=true#step:7:1686). I'll be able to look at it again next week.

stijnvanhoey commented 2 years ago

thanks @dbkhout, the failed tests in the PR are due to the limit on secrets in github actions from forks (something I'll have to look at on how to improve this).

dbkhout commented 2 years ago

You're welcome @stijnvanhoey, thank you for guiding me through my first public PR.