Completes the WIP CMake config for find_package

ilumsden commented 1 month ago

The big thing this PR does is complete @JaeseungYeom's WIP DYADConfig.cmake and similar stuff for exporting DYAD and making it compatible with find_package(DYAD CONFIG).

It also does the following more minor things:

Makes the naming of install path variables (e.g., DYAD_INSTALL_INCLUDE_DIR) more consistent and tweaks the values to be more consistent with expected behavior for installation paths
Replaces the glibc version check with a portable version
Replaces the CMake targets that added -Werror with a macro that will directly add the flag to targets with target_compile_options

In case we want to revert any of these changes, this PR currently does not delete any of the old code. Instead, the old code is just all commented out.

These changes have all been tested with the unit testing from the in-progress refactor/enhancement of the A4MD benchmark. Thanks to that, I can confirm that these changes allow external projects to properly use DYAD as a dependency with find_package.

ilumsden commented 2 weeks ago

This PR has been rebased on top of #117. It should only be merged once #117 is merged

ilumsden commented 2 weeks ago

This PR is ready for review @hariharan-devarajan @JaeseungYeom. Just note that it shouldn't be merged before #117

flux-framework / dyad

Completes the WIP CMake config for find_package #116