search

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner
GNU Lesser General Public License v3.0
7 stars 5 forks source link

Hotfix: fixes CI by correcting cpp-logger and DLIO profiler/dftracer stuff #117

Closed ilumsden closed 2 months ago

ilumsden commented 3 months ago

While looking at CI for other PRs, I found that GitHub Actions was failing to build DYAD because it couldn't find cpp-logger. After looking into the issue, I realized that our check for the <PackageName>_FOUND variable after find_package was simply using the wrong variable name. It was using CPP_LOGGER_FOUND, while it should have been using cpp-logger_FOUND. This PR corrects that variable name.

After fixing this issue with cpp-logger, I also discovered that CI was failing due to @hariharan-devarajan's recent renaming of DLIO profiler to dftracer. This PR also modifies the Python bindings to use the new name (and other minor API changes in dftracer).

hariharan-devarajan commented 3 months ago

@ilumsden We will have to switch DYAD_PROFILER macros to use DFTracer as well.

ilumsden commented 3 months ago

Good point. I was only thinking about it from the Python side since that was the only place where things were failing in CI. But, if I'm going to make these changes in the Python API, I should do it in the main body of DYAD too. I'll work on that after lunch

hariharan-devarajan commented 3 months ago

I recommend doing a search on DLIO_PROFILER and replacing it with DFTRACER.

You will have macros, apis, env variables.

ilumsden commented 3 months ago

@hariharan-devarajan I made all the changes you requested.

JaeseungYeom commented 2 months ago

There are many needless styling modifications in this PR. Refrain from that in the future and focus on what the PR intends to fix.