search

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner
GNU Lesser General Public License v3.0
7 stars 5 forks source link

Adds a License #3

Closed ilumsden closed 2 years ago

ilumsden commented 2 years ago

This is something minor, but important, that I thought of while talking with some members of GCLab.

This PR adds a License to DYAD. The specific license added is LGPL-3, the same license that appears to be used by every other repo in flux-framework.

garlick commented 2 years ago

This might be a bit more complex since there are GPL headers on some of the source files and GPL cannot be included in a LGPL project. Also you're missing the NOTICE.LLNS file, and should note the LLNL release number in the README.md like the other framework projects.

I assume it was decided early on that dyad was part of the flux framework and would fall under the existing license/release number. Just be aware that originally flux was GPL, then we got a new number and switched to LGPL. Part of switching meant excising any vendored source that had a license that was incompatible with LGPL. We could just change the license on the files that we wrote. I think you have a choice of remaining GPL here if convenient or updating to the new release number and LGPL.

ilumsden commented 2 years ago

Thanks for the info @garlick. To be honest, I had just added this because I thought it would be useful to have a license now that DYAD is open source. I wasn't aware of all these details. In hindsight, I probably should have discussed with @JaeseungYeom before making this PR.

Still, on my end, it's quite useful to know about these details. Thanks again.

JaeseungYeom commented 2 years ago

Thank for letting us know the details. Yes, the plan was that dyad to be a part of flux framework. Dong created the placeholder repo a while ago. We are trying to populate the repo now. I do not see a reason not to follow Flux License. However, we will check.

JaeseungYeom commented 2 years ago

I created another PR #4 that replaces the GPL headers in source files. Currently communicating with license expert to make sure that there is no issue with dependency handling.

JaeseungYeom commented 2 years ago

This PR can be cancelled now.