search

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner
GNU Lesser General Public License v3.0
7 stars 5 forks source link

Adds a function to get DYAD file metadata #54

Closed ilumsden closed 10 months ago

ilumsden commented 10 months ago

This PR adds a new function to the Core library: dyad_get_metadata. This function accepts a file path as input, and, if metadata about that file is found in the Flux KVS, it will return that metadata to the user.

Additionally, this PR adds Python bindings to the new dyad_get_metadata function.

Due to the Python binding, this PR depends on #27

ilumsden commented 10 months ago

@JaeseungYeom @hariharan-devarajan this PR is ready for review. I'm not sure why GitHub is complaining about a conflict in bindings.py. All that's changed is that I've added some things, and I replaced import os with import weakref.

JaeseungYeom commented 10 months ago

Can you list what the changes are? I am not sure if you are adding a new function or replacing an existing function. The latter relies on the future for a reason but that seems to be absent in the new function.

hariharan-devarajan commented 10 months ago

@ilumsden do u know why the CI failed here?

ilumsden commented 10 months ago

It seems to be an error from apt. No clue why that would happen. None of my changes touch the tank file, so nothing I've done should cause this

hariharan-devarajan commented 10 months ago

add sudo apt-get update before u do install.