Closed ilumsden closed 7 months ago
@ilumsden I will be looking into this actively. I will look at your branch and continue this work from here.
Did the following changes.
@JaeseungYeom I fixed all the changes we talked about. Let me know if u think i should change anything else.
Usually when I forgot to specify CMAKE_INSTALL_PREFIX
with cmake command, I still make it work by editing the variable in cmake_install.cmake
that is generated under build directory. However, I see INSTALL DESTINATION
is fixed rather than depending on CMAKE_INSTALL_PREFIX
. Can this behavior changed?
Also, can you confirm the python test is working?
Usually when I forgot to specify
CMAKE_INSTALL_PREFIX
with cmake command, I still make it work by editing the variable incmake_install.cmake
that is generated under build directory. However, I seeINSTALL DESTINATION
is fixed rather than depending onCMAKE_INSTALL_PREFIX
. Can this behavior changed?
I fixed it can u check it?
Also, can you confirm the python test is working?
It is working locally but not on CI.
Usually when I forgot to specify
CMAKE_INSTALL_PREFIX
with cmake command, I still make it work by editing the variable incmake_install.cmake
that is generated under build directory. However, I seeINSTALL DESTINATION
is fixed rather than depending onCMAKE_INSTALL_PREFIX
. Can this behavior changed?I fixed it can u check it?
Yes. It works.
Should python binding be installed as well?
Should python binding be installed as well?
Generally it's done the other way around where we install cmake project from pip. I can show u an example with that and discuss the changes in a different pr
Since @hariharan-devarajan mentioned that we wanted to do this and since I had some free time on the flight to SC, I just went ahead and started implementing a CMake-based build system for DYAD.
As of now, this PR just implements a drop-in replacement for autotools. It does not restructure the code base, add any major changes to the code, etc.
In case anyone else wants to contribute to this, I put the branch directly on this repo (as opposed to a fork).