Build: link libb64 when urpc is enabled

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner

GNU Lesser General Public License v3.0

7 stars 5 forks source link

Build: link libb64 when urpc is enabled #6

Closed JaeseungYeom closed 7 months ago

JaeseungYeom commented 2 years ago

added the handler (encoder/decoder) for the binary file payload encoded in b64 text
link libb64 when configured with --enable-urpc
- env variable LIBB64_DIR needs to be set or given as configure --enable-urpc LIBB64_DIR=libb64_install_path
avoid installing *.la and *.a for the modules and the wrapper, which are supposed to be dynamic libraries (*.so)
removed files that are no longer in use

garlick commented 1 year ago

This isn't a review comment on this PR but I noticed libb64 pop up and wondered if you knew about the embeddable base64 implementation in ccan? We've pulled that in to flux-core along with other useful ccan modules e.g. see here. Just thinking maybe dyad would benefit if users don't have to install/configure an external package for base64.

Just a minor suggestion - please pardon the interruption.

JaeseungYeom commented 1 year ago

That is an excellent suggestion. I have been looking for such a variation of base64 library. It looks like there is a way for users to avoid the dependency detail. However, it seems that I need to learn the new interface and re-implement the feature I am adding.