search

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner
GNU Lesser General Public License v3.0
7 stars 5 forks source link

Build: cmake enhancement #65

Closed JaeseungYeom closed 7 months ago

JaeseungYeom commented 7 months ago
  1. Add compiler specific cmake controls
  2. Add config header generation to avoid passing compiler flags via -D
  3. GNUInstallDir based path
  4. Option to promote compilation warnings to errors

For some reason, I see some files missing under src/dyad/stream.=> I see those under include/dyad

JaeseungYeom commented 7 months ago

Checks are failing due to the compile-time generated header (dyad/dyad_config.h) is not found for some reason. Without -DDYAD_HAS_CONFIG=1, the generated header is not read and compilation will fail. It is set in cmake as the file is generated. However, in Makefile for tests, it needed to be added. This will also need to be added to cmake config exported.