New Caliper Integration

flux-framework / dyad

DYAD: DYnamic and Asynchronous Data Streamliner

GNU Lesser General Public License v3.0

7 stars 5 forks source link

New Caliper Integration #80

Open ilumsden opened 8 months ago

ilumsden commented 8 months ago

This PR usurps #51 for adding Caliper annotations to DYAD.

It builds on the recent code in dyad_profiler.h instead of building a separate library for performance annotations.

This is currently a work-in-progress PR. The remaining things to be done before it is ready for merge are:

[x] Update CMake to find and link Caliper
[x] Test the interface using the work for HiCOMB
[x] After HiCOMB, add support for custom attributes (with help from @daboehme where needed)

ilumsden commented 8 months ago

This PR is built on top of #79 and #81. So, those PRs should be merged before this one.

ilumsden commented 8 months ago

I can confirm that I am getting Caliper files when running the workflow benchmark with these annotations enabled. I still need to verify that the CCTs I get when loading the data into Thicket look right. Once I've verified that, task 2 in the original comment on this PR will be done.

ilumsden commented 8 months ago

Also, I will switch this PR to ready for review after I know the CCTs are good. Task 3 in the original PR comment can be done later if we want to.

ilumsden commented 3 months ago

Todos:

Split explicit C API into another PR
Work with David to finish the last few things for the Caliper annotations

ilumsden commented 2 months ago

@hariharan-devarajan @JaeseungYeom this PR is ready for review