flux-framework / flux-accounting

bank/accounting interface for the Flux resource manager
https://flux-framework.readthedocs.io/projects/flux-accounting/en/latest/index.html
GNU Lesser General Public License v3.0
3 stars 10 forks source link

`add-bank`: add a check when adding a root bank #509

Closed cmoussa1 closed 1 month ago

cmoussa1 commented 1 month ago

Problem

Mentioned in #508, the structure of the flux-accounting database hierarchy of banks and users assumes there is only one root bank (e.g when calculating fair-share), but multiple root banks can be added with the add-bank command.


This PR adds a check when adding a root bank that one does not already exist. If so, an exception is raised.

A couple of existing tests that did not make this assumption have been edited to account for this new check, and I've also added a simple sharness test that ensures an exception is raised when trying to add more than one root bank.

Fixes #508

cmoussa1 commented 1 month ago

Thanks! Setting MWP here