flux-framework / flux-accounting

bank/accounting interface for the Flux resource manager
https://flux-framework.readthedocs.io/projects/flux-accounting/en/latest/index.html
GNU Lesser General Public License v3.0
3 stars 10 forks source link

t: change which user is deleted from association_table #528

Closed cmoussa1 closed 2 weeks ago

cmoussa1 commented 2 weeks ago

Problem

There is a test in t1023-flux-account-banks.t that makes sure the default bank of a user is updated when one of their user/bank rows is deleted from the database by removing it in the test prior, but the wrong user is deleted.


This PR just changes which user is deleted in t1023-flux-account-banks.t.

cmoussa1 commented 2 weeks ago

The test continued to pass because the grep check was lazy (and my fault); grep -w "username: user5015\|bank: F\|default_bank: F" new_default_bank.out was checking for a whole-word match for one of the patterns instead of all three. I changed this grep check to be more strict and check that all three were present.

Setting MWP here