search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
159 stars 49 forks source link

broker: avoid 60s delay on follower shutdown #6034

Closed garlick closed 3 weeks ago

garlick commented 3 weeks ago

Problem: when the upstream broker is offline, it takes 60s for systemctl stop flux to complete.

The overlay.goodbye RPC has a 60s timeout. Just skip it if the broker never made contact with its parent.

Fixes #5991

This seems to resolve the issue on my test system.

garlick commented 3 weeks ago

Thanks! Setting mwp.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.29%. Comparing base (2b10588) to head (b54a536).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6034 +/- ## ========================================== - Coverage 83.31% 83.29% -0.02% ========================================== Files 519 519 Lines 83674 83677 +3 ========================================== - Hits 69711 69698 -13 - Misses 13963 13979 +16 ``` | [Files](https://app.codecov.io/gh/flux-framework/flux-core/pull/6034?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/broker/overlay.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6034?src=pr&el=tree&filepath=src%2Fbroker%2Foverlay.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2Jyb2tlci9vdmVybGF5LmM=) | `83.66% <100.00%> (-0.33%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6034/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)