Closed chu11 closed 5 days ago
For some strange reason the inception builder is failing and I believe not ok 17 - attach: reports job shell Killed if job shell is killed
is the culprit. I can't imagine my change affecting this test. Adding some dumb debugging commits.
Edit: hmmm, my recent debugs made the fail disappear ... hopefully it's not something racy
re-pushed with tests and removed WIP. I decided not to update any of the setattr("system.foo", bar)
calls lingering around flux b/c I think the "system.foo" makes it a bit more clear what we're setting/configuring.
re-pushed per comments above
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.36%. Comparing base (
122975f
) to head (9629f6b
).
Problem: By default the Jobspec setattr() function sets keys to attributes.key. The default --setattr option in command line options like flux-submit default to set keys to attributes.system.key. This inconsistency can be confusing.
Default Jobspec setattr() to set keys to "attributes.system.key". Adjust command line --setattr option accordingly for tweak.
Fixes #6042
Just throwing up this WIP in case there are any initial objections