search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
159 stars 49 forks source link

actions: only run CI for push on master #6064

Closed trws closed 2 days ago

trws commented 2 days ago

Actions are being slow today, and I think this is part of why.

problem: we currently run CI in full on both push and PR for all branches, and it mostly just fails on push because it doesn't receive label context. What we really need is for push triggered builds to run on master and only PR-triggered otherwise.

solution: limit push event triggers to the master branch.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.34%. Comparing base (da43fd3) to head (e1edcea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6064 +/- ## ======================================= Coverage 83.33% 83.34% ======================================= Files 519 519 Lines 83818 83818 ======================================= + Hits 69852 69855 +3 + Misses 13966 13963 -3 ``` [see 17 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6064/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)
grondo commented 2 days ago

I make heavy use of CI on push to a branch to check my personal fork before opening a PR. I'm assuming this will break that behavior?

trws commented 2 days ago

I actually had to dig into that a bit to find an answer. If we merged this exactly as-is, yes I think it would break that. It also seems the behavior is different for different forks, in fact the tests run on my fork but almost always break, badly. Probably need to do more research here.