search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
167 stars 50 forks source link

flux-perilog-run: timeout not working with `--exec-per-rank` #6073

Closed grondo closed 1 month ago

grondo commented 3 months ago

The default timeout doesn't seem to be firing on actual systems for flux perilog-run prolog. There's testing in the testsuite with local scripts, but not with --exec-per-rank, so perhaps timeouts aren't working in that implementation.

grondo commented 3 months ago

The issue is that the default here

https://github.com/flux-framework/flux-core/blob/855c3f1323d32643ee8127522371f60815cd6f44/src/cmd/flux-perilog-run.py#L90

is overridden because run_with_timeout() is called with timeout=args.timeout and the default for args.timeout is None. So there is no default timeout.

grondo commented 1 month ago

Closed as wontfix