search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

job-archive: remove module #6378

Closed garlick closed 1 month ago

garlick commented 1 month ago

Not needed anymore

garlick commented 1 month ago

oops - looks like there are still some flux-accounting tests that rely on this.

2024-10-17T00:00:13.5772402Z FAIL: t1011-job-archive-interface.t 7 - load job-archive module

chu11 commented 1 month ago

How about adding to the commit message that this fixes ... https://github.com/flux-framework/flux-core/issues/5288

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.55%. Comparing base (0ed5463) to head (c50d761).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6378 +/- ## ========================================== + Coverage 83.29% 83.55% +0.26% ========================================== Files 524 523 -1 Lines 86230 87348 +1118 ========================================== + Hits 71826 72985 +1159 + Misses 14404 14363 -41 ``` [see 302 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6378/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)
garlick commented 1 month ago

Just force pushed after rebasing on current master and caching a couple of dangling man page references in the docs. Will set MWP.