search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

libsubprocess: misc fixes #6379

Closed chu11 closed 1 month ago

chu11 commented 1 month ago

A minor cleanup and few minor fixes.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.49%. Comparing base (0ed5463) to head (cb75705). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6379 +/- ## ========================================== + Coverage 83.29% 83.49% +0.20% ========================================== Files 524 524 Lines 86230 87643 +1413 ========================================== + Hits 71826 73180 +1354 - Misses 14404 14463 +59 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-core/pull/6379?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/common/libsubprocess/ev\_fbuf\_write.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6379?src=pr&el=tree&filepath=src%2Fcommon%2Flibsubprocess%2Fev_fbuf_write.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2NvbW1vbi9saWJzdWJwcm9jZXNzL2V2X2ZidWZfd3JpdGUuYw==) | `87.93% <100.00%> (+1.93%)` | :arrow_up: | | [src/common/libsubprocess/subprocess.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6379?src=pr&el=tree&filepath=src%2Fcommon%2Flibsubprocess%2Fsubprocess.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2NvbW1vbi9saWJzdWJwcm9jZXNzL3N1YnByb2Nlc3MuYw==) | `89.05% <100.00%> (+0.15%)` | :arrow_up: | ... and [302 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6379/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)