Closed chu11 closed 1 month ago
Attention: Patch coverage is 88.23529%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 83.49%. Comparing base (
b37f4fa
) to head (b53e516
). Report is 2 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/common/libsubprocess/local.c | 83.33% | 1 Missing :warning: |
src/common/libsubprocess/remote.c | 90.90% | 1 Missing :warning: |
Problem: There is always a chance a user may destroy a subprocess object when a callback is called (i.e. output callback, state change callback, etc.). This can lead to problems if libsubprocess believes the object is still valid when the callback returns. References are taken on the subprocess object when issuing some callbacks, but it is missing in other callbacks.
Take reference on all callbacks to ensure safety if the user choses the destroy the subprocess in the callback.