Closed grondo closed 1 month ago
Thanks @wihobbs! I actually just pushed one more doc update here: A note/warning about calling start()
multiple times.
I assume this is ok and will set MWP.
Attention: Patch coverage is 91.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 83.52%. Comparing base (
86db3b4
) to head (cb3f4b6
). Report is 5 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/bindings/python/flux/job/journal.py | 91.66% | 1 Missing :warning: |
@wihobbs had pointed out some usability issues with the
JournalConsumer
class yesterday after the PR was merged. This PR tackles those issues.poll()
must be called afterstart()
.RuntimeException
when theJournalConsumer
isn't started beforepoll()
is calledset_callback()
to be called beforestart()
- there's no reason not to allow it.