Closed garlick closed 3 weeks ago
I pushed a change to that failing test so I think this is ready for a review.
Rebased on current master, addressed the codeql warning, and fixed another test that I'm not sure how I missed before.
Attention: Patch coverage is 83.33333%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 53.93%. Comparing base (
13fb49a
) to head (3c9da5c
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/broker/broker.c | 75.00% | 2 Missing :warning: |
src/broker/overlay.c | 88.88% | 1 Missing :warning: |
src/cmd/flux-start.c | 0.00% | 1 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (13fb49a) and HEAD (3c9da5c). Click for more details.
HEAD has 3 uploads less than BASE
| Flag | BASE (13fb49a) | HEAD (3c9da5c) | |------|------|------| |ci-basic|3|0|
Alright, setting MWP here.
Problem: as noted in #6389, a mismatched
bootstrap.hosts
config can result in two hosts ping-ponging back and forth, connecting and causing the the other to be disconnected with a misleading message.This adds the hostname to the
overlay.hello
RPC. The rank was already there. If thehostlist
broker attribute does not confirm the rank to host mapping, deny the connection.Marking as a WIP for now pending inspiration on how to adapt the issue test for #4182 (resource module re-ranking).