search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

frobnicator: allow queue-specific defaults to override global defaults #6403

Closed grondo closed 3 weeks ago

grondo commented 3 weeks ago

As noted in #6400, queue defaults currently do not override global defaults because the global default is applied before queue defaults are checked.

This PR fixes that.

Fixes #6400

grondo commented 3 weeks ago

Thanks! Setting MWP.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (326d404) to head (481f3ec). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...gs/python/flux/job/frobnicator/plugins/defaults.py 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6403 +/- ## ========================================== + Coverage 83.56% 83.58% +0.01% ========================================== Files 524 524 Lines 87636 87634 -2 ========================================== + Hits 73235 73247 +12 + Misses 14401 14387 -14 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-core/pull/6403?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [...gs/python/flux/job/frobnicator/plugins/defaults.py](https://app.codecov.io/gh/flux-framework/flux-core/pull/6403?src=pr&el=tree&filepath=src%2Fbindings%2Fpython%2Fflux%2Fjob%2Ffrobnicator%2Fplugins%2Fdefaults.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2JpbmRpbmdzL3B5dGhvbi9mbHV4L2pvYi9mcm9ibmljYXRvci9wbHVnaW5zL2RlZmF1bHRzLnB5) | `94.64% <91.66%> (+3.26%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6403/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)