search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

broker/test: avoid race in zeromq cleanup #6405

Closed chu11 closed 3 weeks ago

chu11 commented 4 weeks ago

Problem: There is a small chance of receiving EADDRINUSE from an overlay_bind() call if a prior test has not fully cleaned itself up.

Retry overlay_bind() if EADDRINUSE is hit.

Fixes #6404

chu11 commented 3 weeks ago

re-pushed, going with an alternate solution per discussion in #6404

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.58%. Comparing base (98a4348) to head (531e083). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6405 +/- ## ========================================== - Coverage 83.58% 83.58% -0.01% ========================================== Files 524 524 Lines 87636 87636 ========================================== - Hits 73250 73249 -1 - Misses 14386 14387 +1 ``` [see 14 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6405/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)