search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

WIP job-manager: use subprocess kill not flux imp kill #6410

Closed garlick closed 3 weeks ago

garlick commented 3 weeks ago

Problem: housekeeping and perilog use 'flux imp kill' to implement send signals to housekeeping and prolog/epilog processes, but the 'flux imp kill' subcommand is being deprecated in favor of having the IMP forwarding signals.

Don't configure bulk-exec with the imp path so that bulk_exec_kill() will use flux_subprocess_kill().

Fixes #6409

(don't merge before we have a flux-security release with flux-framework/flux-security#188 in it)

garlick commented 3 weeks ago

Will combine this with #6408 - withdrawing.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.58%. Comparing base (0fe32a4) to head (980229f). Report is 10 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6410 +/- ## ======================================= Coverage 83.57% 83.58% ======================================= Files 524 524 Lines 87634 87628 -6 ======================================= + Hits 73244 73245 +1 + Misses 14390 14383 -7 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-core/pull/6410?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/modules/job-manager/housekeeping.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6410?src=pr&el=tree&filepath=src%2Fmodules%2Fjob-manager%2Fhousekeeping.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL21vZHVsZXMvam9iLW1hbmFnZXIvaG91c2VrZWVwaW5nLmM=) | `82.67% <ø> (+0.17%)` | :arrow_up: | | [src/modules/job-manager/plugins/perilog.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6410?src=pr&el=tree&filepath=src%2Fmodules%2Fjob-manager%2Fplugins%2Fperilog.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL21vZHVsZXMvam9iLW1hbmFnZXIvcGx1Z2lucy9wZXJpbG9nLmM=) | `82.62% <ø> (+0.34%)` | :arrow_up: | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)