flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

libflux: functions for creating out of tree watchers are brittle with respect to ABI #6433

Closed garlick closed 2 weeks ago

garlick commented 2 weeks ago

Problem: a new member cannot be added to struct flux_watcher_ops as discussed in #4156 without breaking ABI because the public function flux_watcher_create() takes a pointer to one as an argument.

To make this less brittle, we could add some padding to the structure.

However I'm not sure there was ever any demand for creating new flux watchers out of tree, and we might want to make the ops struct and associated functions private until they are stable and there is demonstrated need for them out of tree.