flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

libflux: add flux_watcher_is_active() #6436

Closed garlick closed 1 week ago

garlick commented 1 week ago

This reworks @grondo's withdrawn PR to use the method discussed in #4156.

It removes the following functions from the public API:

Note that #6316 broke this ABI without us noticing, two releases ago. It seemed better to just remove these functions for now than try to make the ABI more robust to change when we don't think anybody actually needs it.

There is some gratuitous cleanup of libflux includes, because I repeatedly found myself dealing with circular dependencies. That could be split off to another PR if desired.

garlick commented 1 week ago

Fixed the commit message issues, added tests for zmq watcher and buffer watchers, and added a missing issue reference. I'll set MWP, thanks!