search

flux-framework / flux-core

core services for the Flux resource management framework
GNU Lesser General Public License v3.0
168 stars 50 forks source link

librlist: avoid unnecessary hwloc dependencies #6450

Closed garlick closed 5 days ago

garlick commented 5 days ago

Problem: the librlist.la convenience library includes code that requires hwloc, but often the hwloc bits are not needed.

Split the hwloc parts into a separate convenience library, librlist-hwloc.la.

This also drops the ffi python binding for rlist_from_hwloc(), which probably is fine.

garlick commented 5 days ago

Thanks!

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (7d308c9) to head (e1f2183). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/common/librlist/rhwloc.c 70.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6450 +/- ## ========================================== + Coverage 83.61% 83.64% +0.03% ========================================== Files 523 523 Lines 87505 87505 ========================================== + Hits 73167 73195 +28 + Misses 14338 14310 -28 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-core/pull/6450?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/common/librlist/rlist.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6450?src=pr&el=tree&filepath=src%2Fcommon%2Flibrlist%2Frlist.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2NvbW1vbi9saWJybGlzdC9ybGlzdC5j) | `86.09% <100.00%> (+0.32%)` | :arrow_up: | | [src/modules/resource/inventory.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6450?src=pr&el=tree&filepath=src%2Fmodules%2Fresource%2Finventory.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL21vZHVsZXMvcmVzb3VyY2UvaW52ZW50b3J5LmM=) | `79.09% <ø> (ø)` | | | [src/common/librlist/rhwloc.c](https://app.codecov.io/gh/flux-framework/flux-core/pull/6450?src=pr&el=tree&filepath=src%2Fcommon%2Flibrlist%2Frhwloc.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL2NvbW1vbi9saWJybGlzdC9yaHdsb2MuYw==) | `84.11% <70.00%> (-3.03%)` | :arrow_down: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-core/pull/6450/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)

🚨 Try these New Features: