search

flux-framework / flux-k8s

Project to manage Flux tasks needed to standardize kubernetes HPC scheduling interfaces
Apache License 2.0
20 stars 10 forks source link

chore: rename utils to podspec #78

Closed vsoch closed 3 weeks ago

vsoch commented 3 weeks ago

Problem: the "utils" package in fluence does not describe what it does, and these functions are hard for the developer to find. Solution: rename to podspec to reflect this is what the package is oriented to do.

This will close #77

vsoch commented 3 weeks ago

Amazing - I just moved a change between commits and I didn't break anything. There must be a lot of pigs flying outside today.

vsoch commented 3 weeks ago

No rush to review these @milroy - please take care of the :fire: first.

vsoch commented 3 weeks ago

Thanks @cmisale ! Is it OK if I ping you for future reviews? I wasn't sure if you had the bandwidth since the project was coming to a close.

cmisale commented 3 weeks ago

Absolutely! I'm incredibly quiet but I follow. I always take a look at every PR added me as reviewer even tho some are very big and cannot look at everything with the care I'd like..

vsoch commented 3 weeks ago

Thank you :pray: I didn't know! I apologize for not asking for your review before - I didn't want to burden you.

vsoch commented 3 weeks ago

I'll try to keep them as small / scoped as possible - that first one was... :exploding_head:

cmisale commented 3 weeks ago

No need to apologize :| I've been absent for some time, so it's totally understandable. And haha yes, the first one was huge lol