search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

mergify: replace deprecated strict merge strategy #51

Closed grondo closed 2 years ago

grondo commented 2 years ago

Problem: Mergify has deprecated strict mode merge in favor of using merge queues.

Update the mergify config to use a default merge queue with a rebase and merge strategy which seems to match the strict behavior from before.

Drop the status checks from the mergify.yml, since these largely seem to be redundant with GitHub branch protections. (Mergify will not merge until all branch protections are met.)

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (f31dc0c) into main (6db3d42) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   78.45%   78.45%           
=======================================
  Files          10       10           
  Lines        1188     1188           
=======================================
  Hits          932      932           
  Misses        256      256

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6db3d42...f31dc0c. Read the comment docs.

grondo commented 2 years ago

This one will have to be approved and merged manually.

garlick commented 2 years ago

I swoop in at the last minute to push the button and claim the victory!