search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

update openpmix and ompi versions #61

Closed garlick closed 1 year ago

garlick commented 1 year ago

Problem: flux-pmix does not work with the newer openpmix and ompi 5 branches

Nail down the versions that we test with in CI now that ompi v5 has tagged releases. Choose a version of openpmix that matches the one in the opmi release's submodule reference.

The new version required different namespace setup, so do what appears to be the minimum to get things working.

Also: use the new taskmap interface to create the "maps" pmix wants instead of constructing by hand.

codecov[bot] commented 1 year ago

Codecov Report

Merging #61 (70d3712) into main (44256f0) will increase coverage by 0.71%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   78.46%   79.18%   +0.71%     
==========================================
  Files          10       10              
  Lines        1189     1220      +31     
==========================================
+ Hits          933      966      +33     
+ Misses        256      254       -2
Impacted Files Coverage Δ
src/shell/plugins/fence.c 84.11% <ø> (ø)
src/shell/plugins/infovec.c 93.75% <100.00%> (+2.61%) :arrow_up:
src/shell/plugins/main.c 80.47% <100.00%> (+1.62%) :arrow_up:
src/shell/plugins/maps.c 86.44% <100.00%> (-0.05%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

garlick commented 1 year ago

Withdrawing this PR which is a bit all over the place. Replacing with #62.