search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

fix spurious test failure and add improved debug #71

Closed garlick closed 1 year ago

garlick commented 1 year ago

Zeroing pmix_value_t storage before use seems to both shut up valgrind and resolve issue #69. As pointed out by @grondo, the supposed fix may just be eliminating spurious valgrind warnings. Why the issue goes away is unknown, but maybe there's some other effect going on in the pmix server code that I'm missing. I guess we can reopen if it recurs.

codecov[bot] commented 1 year ago

Codecov Report

Merging #71 (f9ef450) into main (5dae64c) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   79.03%   79.10%   +0.06%     
==========================================
  Files          10       10              
  Lines        1207     1211       +4     
==========================================
+ Hits          954      958       +4     
  Misses        253      253
Impacted Files Coverage Δ
src/shell/plugins/codec.c 70.09% <100.00%> (+0.09%) :arrow_up:
src/shell/plugins/fence.c 84.11% <100.00%> (ø)
src/shell/plugins/infovec.c 93.91% <100.00%> (+0.16%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

garlick commented 1 year ago

Thanks, setting MWP!