flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

make testing of ompi < v5 more robust #72

Closed garlick closed 1 year ago

garlick commented 1 year ago

Problem: since PMI-1 is always active, it's not entirely clear that the testsuite covers using pmix to bootstrap ompi version < v5.

Disable PMI-1 service with -o mpi=off in the MPI tests. Add some checks in the mpi tests to ensure multiple singletons are not started.

Toss in another small change to zero more pmix_value_t objects in test programs.

codecov[bot] commented 1 year ago

Codecov Report

Merging #72 (2e7cad8) into main (9647b92) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files          10       10           
  Lines        1231     1231           
=======================================
  Hits          978      978           
  Misses        253      253           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more