search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

support pmix-3.2.3 #80

Closed garlick closed 1 year ago

garlick commented 1 year ago

As noted in #79, TOSS 4 ships pmix-3.2.3 so here's a first cut at trying to support it.

This is WIP pending some thought about CI.

garlick commented 1 year ago

we may want to change el8 builder to run with the packaged pmix-3.2.3 and a recent ompi v4.

FWIW, TOSS 4 systems have openmpi 4.1.4 and 4.0.5 installed under /opt/toss/openpmi

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (1da1913) into main (7e27305) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files          12       12           
  Lines        1363     1363           
=======================================
  Hits         1076     1076           
  Misses        287      287
Impacted Files Coverage Δ
src/shell/plugins/main.c 80.34% <ø> (ø)
src/shell/plugins/notify.c 88.46% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

garlick commented 1 year ago

This is probably ready for a review as CI now covers the versions of interest here.

garlick commented 1 year ago

Thanks! Fixed and pushed, and setting MWP.