search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

plugin: use a simpler strategy for the interthread channel #92

Closed garlick closed 11 months ago

garlick commented 11 months ago

Problem: recent changes in flux-core have made the shmem:// connector less convenient to use, and broke flux-pmix.

This swaps out the back-to-back flux_t handles, used for sending messages from the pmix server thread to the shell thread, for a struct flux_msglist protected by mutexes. This should work with all recent flux-core versions, and doesn't require the flux shell to take on a zeromq context, which brings with it some potential issues.

Also CI is updated to build ompi 5.0.0rc12 rather than the 5.0.x development branch, which was failing. We'll deal with getting CI back to tracking upstream 5.0.x development later.

codecov[bot] commented 11 months ago

Codecov Report

Merging #92 (412eb8c) into main (5644138) will decrease coverage by 0.90%. The diff coverage is 73.01%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   79.01%   78.11%   -0.90%     
==========================================
  Files          12       12              
  Lines        1382     1412      +30     
==========================================
+ Hits         1092     1103      +11     
- Misses        290      309      +19
Files Coverage Δ
src/shell/plugins/main.c 75.60% <50.00%> (-5.12%) :arrow_down:
src/shell/plugins/interthread.c 79.54% <79.59%> (-3.56%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more