search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

plugin: pmix notification encoding problems #93

Closed garlick closed 11 months ago

garlick commented 11 months ago

Problem: at one point while working on #89, t0006-notify.t began segfaulting. The segfault disappeared in the eventual solution to #89, however there really was a bug there causing stack corruption.

Fix two problems with message encoding for pmix notifications, and improve unit tests for codec.c.

garlick commented 11 months ago

oops had a poorly worded commit message there - repushed.

codecov[bot] commented 11 months ago

Codecov Report

Merging #93 (d59ffa7) into main (fc67928) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   78.11%   78.13%   +0.01%     
==========================================
  Files          12       12              
  Lines        1412     1413       +1     
==========================================
+ Hits         1103     1104       +1     
  Misses        309      309
Files Coverage Δ
src/shell/plugins/codec.c 70.49% <100.00%> (+0.09%) :arrow_up:
src/shell/plugins/notify.c 88.46% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more