search

flux-framework / flux-pmix

flux shell plugin to bootstrap openmpi v5+
GNU Lesser General Public License v3.0
2 stars 4 forks source link

plugin: set hwloc.xmlfile shell option #95

Closed garlick closed 7 months ago

garlick commented 7 months ago

Problem: flux-pmix does not yet share hwloc with MPI, which forces MPI to go looking for it, sometimes at great cost to performance.

For the time being, tell flux-core to share a hwloc xml file by setting the -o hwloc.xmlfile shell option.

Later we will want to fix #31 properly and drop this.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eff13f6) 78.13% compared to head (c2b2293) 78.09%.

Files Patch % Lines
src/shell/plugins/main.c 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================== - Coverage 78.13% 78.09% -0.04% ========================================== Files 12 12 Lines 1413 1415 +2 ========================================== + Hits 1104 1105 +1 - Misses 309 310 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grondo commented 7 months ago

Went ahead and restarted all the tests

garlick commented 7 months ago

Thanks! I tested this manually with the flux-core -o hwloc.xmlfile feature and it works splendidly. Setting MWP.