search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
86 stars 40 forks source link

Reduce number of dfu_impl_t::select calls #1018

Open milroy opened 1 year ago

milroy commented 1 year ago

Depending on the match_op_t, dfu_impl_t::select can be called many times in dfu_traverser_t::schedule: https://github.com/flux-framework/flux-sched/blob/a9c1bd5d4d9058d148bf5b5cc6a737c28dc1ce4a/resource/traversers/dfu.cpp#L62

We should optimize and simplify the function logic to reduce the number of dfu_impl_t::select calls to reduce the number of traversals per schedule call.

trws commented 1 month ago

Much as I agree with this, I think we're at the minimum we can be right now without getting the fixes in for the pruner constraint/queue issues. Maybe we should change this to be about doing that or close and switch to another issue?

trws commented 1 month ago

Much as I agree with this, I think we're at the minimum we can be right now without getting the fixes in for the pruner constraint/queue issues. Maybe we should change this to be about doing that or close and switch to another issue?