search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

testsuite: fix a couple race conditions in `t4011-match-duration.t` #1109

Closed grondo closed 6 months ago

grondo commented 6 months ago

This PR fixes a couple race conditions in t/t4011-match-duration.t which cause the test to fail occasionally.

codecov[bot] commented 6 months ago

Codecov Report

Merging #1109 (1600ffb) into master (2208821) will increase coverage by 0.0%. The diff coverage is 100.0%.

:exclamation: Current head 1600ffb differs from pull request most recent head 68fd13e. Consider uploading reports for the commit 68fd13e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1109 +/- ## ====================================== Coverage 71.8% 71.8% ====================================== Files 88 88 Lines 11530 11531 +1 ====================================== + Hits 8286 8287 +1 Misses 3244 3244 ``` | [Files](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/modules/resource\_match.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9yZXNvdXJjZV9tYXRjaC5jcHA=) | `67.7% <100.0%> (+<0.1%)` | :arrow_up: |
grondo commented 6 months ago

Thanks @jameshcorbett! I had to restart the spelling and pr-validator checks because they failed for unknown reason. I'll set MWP now.