flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

refactor: optmgr to simpler design, one file #1177

Closed vsoch closed 1 month ago

vsoch commented 1 month ago

Problem: the current optmanager is split into two files and it adds unneeded complexity. There might have been some initial intention for such a design, but it seems overkill for a small class that manages options. Solution: refactor all functions to just be in one file.

I also added the C++ extensions to be provided by the default for the DevContainer - without it I miss the "customize your environment" option that pops up and then allows me to choose my compiler, etc. to get the nice testing buttons on the side. :red_circle: :green_circle:

I chat with @trws about this in our last meeting.

vsoch commented 1 month ago

I'd love to! This was easy and fun. I really appreciate small tasks like this that will (slowly) get me more familiar with fluxion and C++. I'm hoping with enough exposure things will start to click at some point.

vsoch commented 1 month ago

Do I need to rebase and then do merge when passing?

trws commented 1 month ago

I actually don't see any need for a rebase, it's all up to date, and the commit messages look good. Feel free to set MWP.

vsoch commented 1 month ago

If I remember, my researchapps org might not work with the merge train, but we can try again. If it doesn't I can switch over to manbat or just use vsoch.

vsoch commented 1 month ago

woot!