queue_base_manager: refactor to remove impl

flux-framework / flux-sched

Fluxion Graph-based Scheduler

GNU Lesser General Public License v3.0

84 stars 39 forks source link

queue_base_manager: refactor to remove impl #1178

Closed vsoch closed 4 weeks ago

vsoch commented 1 month ago

Problem: the multiple inheritance adds complexity without obvious benefit. Solution: remove it for the queue_base_manager.hpp (removing *_impl.hpp)

I tried to keep everything in "protected" that I could (that was originally there) until it needed to be used in qmanager, and previously this was done with detail, so I moved those up to public.

vsoch commented 1 month ago

Woot!! Ping @trws :green_circle:

milroy commented 4 weeks ago

Looking now.

vsoch commented 4 weeks ago

With two approvals I can set MWP?

vsoch commented 4 weeks ago

:partying_face:

trws commented 4 weeks ago

Awesome, thanks again @vsoch!