flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

reapi c++: add satisfy endpoint #1184

Open vsoch opened 4 weeks ago

vsoch commented 4 weeks ago

Problem: the c++ bindings do not have satisfy support. Solution: add satisfy to them.

In practice I was adding this for exposure to the Go bindings, but I do not think it is necessary, because the Go bindings use the C bindings, which already have reapi_cli_match_satisfy. I saw that match_allocate seems to have support to provide the SATISFIABILITY match_op, which is provided to the traverser, so I tried to call that same function. I am opening this PR in case it is interesting or useful. If not, please close and disregard.

If the PR is desired, here are questions I have:

And again, if this is not of interest, please disregard! Going to do some work on fluxion-go next.

codecov[bot] commented 4 weeks ago

Codecov Report

Merging #1184 (f08ad38) into master (1c68ec6) will decrease coverage by 0.2%. Report is 31 commits behind head on master. The diff coverage is 0.0%.

:exclamation: Current head f08ad38 differs from pull request most recent head c9fb2bf. Consider uploading reports for the commit c9fb2bf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1184 +/- ## ======================================== - Coverage 73.9% 73.8% -0.2% ======================================== Files 103 102 -1 Lines 14396 14396 ======================================== - Hits 10644 10627 -17 - Misses 3752 3769 +17 ``` | [Files](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1184?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/reapi/bindings/c++/reapi\_cli\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1184?src=pr&el=tree&filepath=resource%2Freapi%2Fbindings%2Fc%2B%2B%2Freapi_cli_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcmVhcGkvYmluZGluZ3MvYysrL3JlYXBpX2NsaV9pbXBsLmhwcA==) | `36.8% <0.0%> (-0.6%)` | :arrow_down: | | [resource/reapi/bindings/c++/reapi\_module\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1184?src=pr&el=tree&filepath=resource%2Freapi%2Fbindings%2Fc%2B%2B%2Freapi_module_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcmVhcGkvYmluZGluZ3MvYysrL3JlYXBpX21vZHVsZV9pbXBsLmhwcA==) | `50.3% <0.0%> (-6.8%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1184/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)
vsoch commented 4 weeks ago

I am sorry codecov bot, please forgive my sins :pray: