search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

Update stats output to include data for failed matches #1187

Closed milroy closed 2 weeks ago

milroy commented 3 weeks ago

Performance testing with Fluxion has revealed the need to save and output data on failed matches. This PR updates the resource module to track and report these stats.

milroy commented 2 weeks ago

Thanks for the second round of feedback!

trws commented 2 weeks ago

@garlick, would you like one more pass here or are we ready for MWP?

garlick commented 2 weeks ago

Go ahead. Nice work!

trws commented 2 weeks ago

Ready when you are then @milroy!

milroy commented 2 weeks ago

Thanks for the reviews!

I added a tiny commit to test populating the failed stats path. Once that succeeds I'll set MWP.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 91.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.9%. Comparing base (bb686df) to head (9013583).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1187 +/- ## ====================================== Coverage 73.9% 73.9% ====================================== Files 102 102 Lines 14565 14595 +30 ====================================== + Hits 10766 10790 +24 - Misses 3799 3805 +6 ``` | [Files](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/modules/resource\_match.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1187?src=pr&el=tree&filepath=resource%2Fmodules%2Fresource_match.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9yZXNvdXJjZV9tYXRjaC5jcHA=) | `69.2% <91.4%> (+0.2%)` | :arrow_up: |