search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

ci: update deprecated github actions #1191

Closed grondo closed 2 weeks ago

grondo commented 2 weeks ago

This PR attempts to update all deprecated actions in workflow/main.yml.

As part of the update, the codecov uploader is updated from the bash version to the most recent action uploader. Be aware that this requires that CODECOV_TOKEN be set in the environment of the action (where I don't think the bash uploader did). The main repo gets this from the organization secrets, but if you have a personal fork, you'll have to set the CODECOV_TOKEN secret to continue getting codecov uploads to your user org in codecov.

We'll see how this works in a PR here...

grondo commented 2 weeks ago

There's a big drop in coverage here in qmanager/policies/base/queue_policy_base.hpp and src/common/liboptmgr/optmgr.hpp and I'm not sure the cause, but it should be looked into.

trws commented 2 weeks ago

That is probably expected, because those files now include all the former contents of the <name>_impl.hpp files, that no longer exist. If the coverage is lower than those files, then we have a serious problem, but if it's not then it should just be that refactor showing up.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.9%. Comparing base (1c68ec6) to head (bd31634). Report is 51 commits behind head on master.

:exclamation: Current head bd31634 differs from pull request most recent head 2cefb51. Consider uploading reports for the commit 2cefb51 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1191 +/- ## ======================================== - Coverage 73.9% 73.9% -0.1% ======================================== Files 103 102 -1 Lines 14396 14565 +169 ======================================== + Hits 10644 10766 +122 - Misses 3752 3799 +47 ``` [see 12 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1191/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)
grondo commented 2 weeks ago

Thanks, I'll set MWP and we can rebase the other pending PRs.