search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

Repo cleanup #1195

Open trws opened 2 weeks ago

trws commented 2 weeks ago

Now that we've had the cmake build stable for a while, it's time to remove the autotools build. With that gone, reorganization becomes feasible, so the resource and qmanager directories can now finally live under src.

garlick commented 2 weeks ago

Just a suggestion but maybe split off the repo reorg to a separate PR since the automake removal is an obvious immediate yes and the reorg conflicts with all(?) pending prs and might require more discussion.

trws commented 2 weeks ago

Sure, no problem.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.4%. Comparing base (d2d7b6d) to head (4044a9e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1195 +/- ## ======================================== + Coverage 73.9% 74.4% +0.4% ======================================== Files 102 99 -3 Lines 14595 13853 -742 ======================================== - Hits 10790 10307 -483 + Misses 3805 3546 -259 ``` | [Files](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/qmanager/modules/qmanager.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fmodules%2Fqmanager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL21vZHVsZXMvcW1hbmFnZXIuY3Bw) | `73.3% <ø> (ø)` | | | [src/qmanager/modules/qmanager\_callbacks.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fmodules%2Fqmanager_callbacks.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL21vZHVsZXMvcW1hbmFnZXJfY2FsbGJhY2tzLmNwcA==) | `74.3% <ø> (ø)` | | | [src/qmanager/modules/qmanager\_opts.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fmodules%2Fqmanager_opts.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL21vZHVsZXMvcW1hbmFnZXJfb3B0cy5jcHA=) | `77.1% <ø> (ø)` | | | [src/qmanager/modules/qmanager\_opts.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fmodules%2Fqmanager_opts.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL21vZHVsZXMvcW1hbmFnZXJfb3B0cy5ocHA=) | `100.0% <ø> (ø)` | | | [src/qmanager/policies/base/queue\_policy\_base.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fbase%2Fqueue_policy_base.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL2Jhc2UvcXVldWVfcG9saWN5X2Jhc2UuaHBw) | `72.2% <ø> (ø)` | | | [...rc/qmanager/policies/queue\_policy\_bf\_base\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fqueue_policy_bf_base_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL3F1ZXVlX3BvbGljeV9iZl9iYXNlX2ltcGwuaHBw) | `88.7% <ø> (ø)` | | | [...anager/policies/queue\_policy\_conservative\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fqueue_policy_conservative_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL3F1ZXVlX3BvbGljeV9jb25zZXJ2YXRpdmVfaW1wbC5ocHA=) | `76.9% <ø> (ø)` | | | [src/qmanager/policies/queue\_policy\_easy\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fqueue_policy_easy_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL3F1ZXVlX3BvbGljeV9lYXN5X2ltcGwuaHBw) | `100.0% <ø> (ø)` | | | [...rc/qmanager/policies/queue\_policy\_factory\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fqueue_policy_factory_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL3F1ZXVlX3BvbGljeV9mYWN0b3J5X2ltcGwuaHBw) | `85.0% <ø> (ø)` | | | [src/qmanager/policies/queue\_policy\_fcfs.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree&filepath=src%2Fqmanager%2Fpolicies%2Fqueue_policy_fcfs.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3FtYW5hZ2VyL3BvbGljaWVzL3F1ZXVlX3BvbGljeV9mY2ZzLmhwcA==) | `100.0% <ø> (ø)` | | | ... and [83 more](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1195/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)