search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

autoconf removal #1196

Closed trws closed 2 weeks ago

trws commented 3 weeks ago

As suggested by @garlick over in #1195, splitting out the autotools removal since that's a much easier unit if it doesn't have all the file moves mixed in.

trws commented 3 weeks ago

The extra commit is here because this is where the problem surfaced. I'm not sure why it surfaced here, but the cgo build for the go test was looking for libczmq, which is apparently no longer found in the focal image for some reason.

grondo commented 3 weeks ago

flux-core dropped the czmq dependency awhile ago.

trws commented 3 weeks ago

I saw that, it's extremely odd to me that this just happened now... Maybe it's just when the containers got poked? Not sure.

trws commented 3 weeks ago

Ok, I wasn't planning to rework docker-run-checks.sh for this, so I'll do whatever of that I can without breaking it, or only small tweaks. The ./configure workflow actually works, that's part of why that stuff is there, though yeah it's not necessary.

trws commented 3 weeks ago

Turns out autogen being missing just pops a warning in docker-run-checks.sh AFAICT, so assuming this passes that should be cleaned up.

trws commented 2 weeks ago

Anyone willing to sign off here?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.9%. Comparing base (7a45c25) to head (a49bbd7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1196 +/- ## ====================================== Coverage 73.9% 73.9% ====================================== Files 102 102 Lines 14595 14595 ====================================== Hits 10790 10790 Misses 3805 3805 ```