search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

docker-run-checks: ensure we match user's home #1197

Closed trws closed 1 week ago

trws commented 2 weeks ago

problem: docker-run-checks.sh currently assumes that mounting $HOME to /home/$USER will match the outer system. Sometimes that is not the case. Example, my lima-managed vm uses /home/$USER.linux as the home directory for the vm user, which causes strange errors because of the mismatch.

solution: map $HOME to $HOME

trws commented 1 week ago

Assuming everything passes here, would be nice to get this one matching flux-core.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.9%. Comparing base (d2d7b6d) to head (9274981).

:exclamation: Current head 9274981 differs from pull request most recent head 1f49159. Consider uploading reports for the commit 1f49159 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1197 +/- ## ====================================== Coverage 73.9% 73.9% ====================================== Files 102 102 Lines 14595 14595 ====================================== Hits 10790 10790 Misses 3805 3805 ```