search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
84 stars 39 forks source link

cmake: look for ver file in source directory #1199

Closed trws closed 3 weeks ago

trws commented 3 weeks ago

problem: cmake was looking for the version file in the build directory rather than the source directory, causing it not to be found in some common configurations.

solution: have it look in the source directory instead

trws commented 3 weeks ago

It will not, the make dist command is the one (hopefully only one) command that modifies the source directory. Mainly because it uses archive, and grabs the flux-sched.ver from the root. Thinking back on that now, I really am not fond of that... I'm going to add a command to not write into the source directory, that's just not kosher.

trws commented 3 weeks ago

I almost merged this, but to my utter shock I think I just ran into a bug in git of all things... revising.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.0%. Comparing base (a082acf) to head (0a66f1c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1199 +/- ## ====================================== Coverage 74.0% 74.0% ====================================== Files 102 102 Lines 14611 14611 ====================================== Hits 10822 10822 Misses 3789 3789 ```