search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
89 stars 41 forks source link

pruner: don't track own type for pruning #1228

Closed trws closed 5 months ago

trws commented 5 months ago

problem: the ALL resource type in the pruner specification was including the type of the anchor vertex, so in common uses like "ALL:core" all core vertices allocate a planner to track the number of cores they contain

solution: if the anchor and the target type match, don't track it

This saved roughly 600MB with a 16k node graph with 64 cores per node. Also kinda trivial. Looking for other low-hanging fruit.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.1%. Comparing base (2d5a548) to head (20d5f9f). Report is 173 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1228 +/- ## ====================================== Coverage 74.0% 74.1% ====================================== Files 103 103 Lines 14615 14616 +1 ====================================== + Hits 10823 10835 +12 + Misses 3792 3781 -11 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1228?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/policies/base/matcher.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1228?src=pr&el=tree&filepath=resource%2Fpolicies%2Fbase%2Fmatcher.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcG9saWNpZXMvYmFzZS9tYXRjaGVyLmNwcA==) | `73.0% <100.0%> (+0.1%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)