search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
90 stars 41 forks source link

qmanager: restart the sched loop on updates #1236

Closed trws closed 4 months ago

trws commented 4 months ago

problem: The sched loop can take a long time to receive new updates like cancellations and reprioritize.

solution: Cancel the sched loop either immediately or when the current iteration is done to allow those to proceed when a cancel, reprio or free has been received.

trws commented 4 months ago

Fixed a small formatting nit, I'm good with this one if you are @milroy.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.1%. Comparing base (1161e61) to head (ae4b7b5). Report is 174 commits behind head on master.

Files with missing lines Patch % Lines
qmanager/policies/queue_policy_bf_base_impl.hpp 81.8% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1236 +/- ## ====================================== Coverage 74.1% 74.1% ====================================== Files 103 103 Lines 14537 14552 +15 ====================================== + Hits 10772 10785 +13 - Misses 3765 3767 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1236?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [qmanager/policies/base/queue\_policy\_base.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1236?src=pr&el=tree&filepath=qmanager%2Fpolicies%2Fbase%2Fqueue_policy_base.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cW1hbmFnZXIvcG9saWNpZXMvYmFzZS9xdWV1ZV9wb2xpY3lfYmFzZS5ocHA=) | `78.5% <100.0%> (+0.2%)` | :arrow_up: | | [qmanager/policies/queue\_policy\_bf\_base\_impl.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1236?src=pr&el=tree&filepath=qmanager%2Fpolicies%2Fqueue_policy_bf_base_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cW1hbmFnZXIvcG9saWNpZXMvcXVldWVfcG9saWN5X2JmX2Jhc2VfaW1wbC5ocHA=) | `82.1% <81.8%> (-0.3%)` | :arrow_down: |