search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
89 stars 41 forks source link

chore: flux ion-resource jobspec argument redundancy #1244

Closed vsoch closed 3 months ago

vsoch commented 4 months ago

Problem: the flux-ion-resource.py match has several subcommands that require a jobspec positional argument. Each subparser is calling the same logic to add it, which is redundant. Solution: iterate through a list to add the same argument to all of them, eliminating the redundancy and making it easier for the developer to read.

vsoch commented 3 months ago

Should I update with rebase, and is from the GitHub UI ok? I don't want to do it wrong and have to do another PR.

jameshcorbett commented 3 months ago

Github UI should be OK. It may do it for you when all the checks pass? I'm not sure. Otherwise git checkout master; git pull; git checkout simplify-parse-match; git rebase master; git push -f

trws commented 3 months ago

Huh, odd, mergify should have done it for you. Try the github UI, should kick everything forward.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.3%. Comparing base (c80d09b) to head (64c01c1). Report is 119 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1244 +/- ## ====================================== Coverage 75.3% 75.3% ====================================== Files 107 107 Lines 15128 15128 ====================================== Hits 11405 11405 Misses 3723 3723 ```